Detect support of touch-action none #955
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds detection of the touch-action none property with CSS.supports. Required to fix iOS 9.3 support, since it hasn't implement the touch-action completely.
|
What i was doing was a bit more complex. What i am doing is to detect which properties are supported and save that then. When we try to use one, check support for that particular prop. Then when supported we could use manipulation, and if apple decides to add another prop with out adding the whole set we wont break again. |
|
@arschmitz a more holistic solution makes sense to me, I doubt 9.3 is the last browser to break, and there's probably a number of minor browsers we never use that have issues with this. |
|
@runspired my thoughts exactly i should have PR ready tonight |
arschmitz
added a commit
to arschmitz/hammer.js
that referenced
this pull request
Apr 4, 2016
arschmitz
added a commit
to arschmitz/hammer.js
that referenced
this pull request
Apr 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds detection of the touch-action none property with CSS.supports. Required to fix iOS 9.3 support, since it hasn't implement the touch-action completely.
Needs some verification since I don't own an iOS device. @arschmitz