Suggest change event flow #818
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| equal(eventflow,"startleftend"); | ||
| start(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Minor nit pick your missing a new line at end of file
|
@runspired This change makes sense to me its what mouse events do. What do you think? |
|
Seems to make sense but I'm on my phone |
|
Looked closer, this is good, and fixes several open issues |
|
Would fix #824 |
|
@arschmitz @runspired |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I suggest change event flow.
The PanRecognizer have "pan(start|move|end|cancel)" and "pan(left|right|up|down)" event. The PinchRecognizer have "pinch(start|move|end|cancel)" and "pinch(in|out)" event.
The "emit" method of Recognizer is fire "pan(start|move|end|cancel)", "pinch(start|move|end|cancel)".The "emit" method of Manager is fire "pan(left|right|up|down)", "pinch(in|out)" .
The "emit" method of PanRecognizer call step is
1. Manager#emit call
2. Recognizer#emit call
So. The event flow of PanRecognizer is "pan(left|right|up|down) -> panstart -> (left|right|up|down) ....-> panend".
The "emit" method of PinchRecognizer call step is
1. Recognizer#emit call
2. Manager#emit call
So. The event flow of PinchRecognizer is "pinchstart -> pinch(in|out) .... -> pinchend -> pinch(in|out)".
Event flow is different from each other. [sample]
I suggest that same event flow.