Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't round pointer position in simpleCloneInputData #1231

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

upsuper
Copy link

@upsuper upsuper commented Aug 27, 2019

This rounding was added back to 432d2fe. There was no explanation why it was done that way.

However, this leads to a problem that a gesture can immediately trigger a change on the very first event, which can be undesirable.

@upsuper
Copy link
Author

upsuper commented Aug 27, 2019

Actually, such rounding basically makes threshold of PinchRecognizer useless, because for example 16.5 / 17 = 0.97 which is already 3% different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant