Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] Hammer's Default Configuration Leaves Gesture Detection Gaps #838

Closed
runspired opened this issue Aug 7, 2015 · 4 comments
Closed

Comments

@runspired
Copy link
Contributor

Gaps currently exist between pan and swipe, and between tap and press. This is especially confusing for new users who just want to drop it in and play.

These gaps may be problematic for detecting any taps on some mobile devices. A hypothesis is that this relates to pixel density. The default tap movement threshold should likely be adjusted higher (to meet pan at 9px, possibly more), to avoid issues like #804

Velocity settings (and default configuration) should be explained. Most velocity values will lead to very few swipes being registered. It's possible we might want to provide a few scenarios for when to use pan versus when to use swipe. It seems much swipe usage is better suited for and likely intended to be pan usage, but the difference between the mental constructs is poorly understood.

The following affected issues are closed by this meta ticket.

The following affected issues are not closed by this meta ticket.

@holic
Copy link

holic commented Aug 7, 2015

By default configuration, does this mean the options that define each gesture or the default Hammer instance (as opposed to Hammer.Manager)?

@runspired
Copy link
Contributor Author

It applies to both.

@holic
Copy link

holic commented Aug 7, 2015

Great. I am seeing issues with Samsung devices specifically when trying to recognize gestures using an instance of Hammer.Manager. Looking forward to the improvements!

arschmitz pushed a commit that referenced this issue Aug 7, 2015
Fixes determination of if it is acceptable to prevent the browser default behavior of scrolling/zoom etc when the touch-action property is set to none and the browser does not provide native support for the touch-action property. It fails to differenciate between a tap gesture and a multi-touch gesture which results in click and hover events from not getting recognized when an element has multi-touch gesture associated with it.

Ref #838
Ref #808
Closes #762
@runspired
Copy link
Contributor Author

Closed by #860

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants