Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cidr2ips method #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mingoooo
Copy link

I have a requirement, cidr convert to a list of ip address.This is my code, maybe someone needs it.

@hamishforbes
Copy link
Owner

Cool, that seems useful!

The only thing I would say is if the cidr doesn't parse we should probably return the error rather than logging it unconditionally.
The only place we log rather than return is when parsing multiple cidrs, this is so the other potentially valid cidrs are still returned.

A couple basic tests would be good too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants