Fixed multiple identical substring matching in StringContainsInOrder #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ameter strings with the same substring occurrence
Contributor
|
This would change existing behaviour but I expect affected code would be very rare. Since we have a major version bump coming up, this would be a good time to merge this change. |
Contributor
|
Merged into the v7.0 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringContainsInOrder instances might expect multiple occurrences of identical substrings in the string to be matched. However, since this matcher requires all substrings to be in order, they must match distinct occurrences. This behavior is imposed with this fix.
Example:
StringContainsInOrder m1 = new StringContainsInOrder(asList("a", "b", "c"));StringContainsInOrder m2 = new StringContainsInOrder(asList("a", "b", "c", "c"));The matcher
m1is expected to match"abc", howeverm2is not. Unless this fix is pulled, bothm1andm2matches"abc".