AX25 encoding fixes. #302
Merged
AX25 encoding fixes. #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wb8tyw
requested review from
KP4AJ,
dslotter,
flyingfrawg,
ka5mye,
maurizioandreotti,
riggs498 and
yo2loj
Contributor
Author
|
If anyone can test this with a packet modem, physical or software that would be great. The previous code had the potential of creating invalid UTF-8 sequences which would have resulted in corrupted data. |
This was
linked to
issues
Mar 22, 2025
Contributor
Author
|
Add a fix for a newly discovered fix for potential packet drop issue. |
Contributor
Author
|
Added changes entries. |
Github user dscp46 F4HOF discovered a potential data corruption in AX25 frame encoding and the control byte. In Python3, you can not to some bit manipulations on the str data type as that has to contain valid Unicode characters. One of the bytes types must be used instead. Github user dscp46 F4H0F discovered an additional character that needs to be Yencoded to prevent packet loss d-rats_in_mobaxterm_install.sh: Reports that newerverions of mobaxterm do not have busybox pre-installed. d_rats/agw.py: d_rats/comm.py: d_rats/wlk.py: Change to use bytes type for properly encoding binary. d_rats/yencode.py: Blacklist additional characters for D-Star and AX-25 packets changes/*: Documentation for bug fixes for News file Others: Spelling and pylint fixes found.
Contributor
Author
|
Found some more character codes that need to be blacklisted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github user dscp46 discovered a potential data corruption in AX25 frame encoding and the control byte.
In Python3, you can not to some bit manipulations on the str data type as that has to contain valid Unicode characters. One of the bytes types must be used instead.
d-rats_in_mobaxterm_install.sh:
Reports that newerverions of mobaxterm do not have busybox
pre-installed.
d-rats/agw.py:
d-rats/comm.py:
d-rats/wlk.py:
Change to use bytes type for properly encoding binary.
Others:
Spelling and pylint fixes found.