Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: add a guide to set up shared url #5

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Dec 5, 2022

进入 Umami 仪表盘时,如果没有设置 Umami 共享链接,那么提示+引导使用者进入设置。

image

/kind improvement

可测试插件:plugin-umami-1.0.0-SNAPSHOT.jar.zip

None

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note-none Denotes a PR that doesn't merit a release note. labels Dec 5, 2022
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang December 5, 2022 08:48
Copy link
Contributor

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议提供一个方便 reviewer 测试的 jar 包(可提前压缩成 zip 包后上传)。

@ruibaby
Copy link
Member Author

ruibaby commented Dec 5, 2022

@JohnNiang 已上传。

Copy link
Contributor

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2022
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit 370e177 into halo-sigs:main Dec 6, 2022
@ruibaby ruibaby deleted the perf/error-dialog branch December 6, 2022 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants