Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support image zooming based on page rules #6

Merged
merged 5 commits into from
Jun 19, 2023
Merged

Conversation

guqing
Copy link
Member

@guqing guqing commented Jun 16, 2023

What this PR does?

支持配置页面路径规则匹配来开启图片放大功能

Fixes #5

image
支持配置页面路径规则匹配来开启图片放大功能

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 16, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby June 16, 2023 09:52
@ruibaby
Copy link
Member

ruibaby commented Jun 16, 2023

Amazing!

@ruibaby
Copy link
Member

ruibaby commented Jun 17, 2023

image

似乎在任意页面都会追加这些 js。

image

@guqing
Copy link
Member Author

guqing commented Jun 19, 2023

似乎在任意页面都会追加这些 js。

Done

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 95521e4 into main Jun 19, 2023
@guqing guqing deleted the feature/5 branch June 19, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

增加页面匹配功能
2 participants