Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ids to headings #4

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 8, 2023

为渲染的 HTMl 中的 heading 标签(h1、h2、h3 .etc)添加 id。

Fixes #3

/kind feature

可测试 JAR 包:plugin-bytemd-1.0.0-SNAPSHOT.jar.zip

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 8, 2023
@JohnNiang
Copy link

需要解决一下冲突。

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2023
@ruibaby
Copy link
Member Author

ruibaby commented Feb 13, 2023

@halo-sigs/halo

Copy link

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 119b345 into halo-sigs:main Feb 16, 2023
@ruibaby ruibaby deleted the chore/heading-ids branch February 16, 2023 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

最终生成的html文档中的h1,h2,h3等标签没有随机id
3 participants