Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename displayName to S3 对象存储 #128

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Mar 23, 2024

在 Halo 完成动态数据的 i18n 之前,使用中文描述存储策略名称。

/kind improvement

image
修改存储策略名称为中文显示。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Mar 23, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and minliacom March 23, 2024 13:21
Copy link

f2c-ci-robot bot commented Mar 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2024
Copy link
Member

@longjuan longjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 034b3f3 into halo-dev:main Mar 24, 2024
4 checks passed
f2c-ci-robot bot pushed a commit to halo-dev/halo that referenced this pull request Mar 31, 2024
#### What type of PR is this?

/area core
/kind improvement
/milestone 2.14.0

#### What this PR does / why we need it:

在 Halo 完成动态数据的 i18n 之前,使用中文描述存储策略名称。

Ref halo-dev/plugin-s3#128

#### Does this PR introduce a user-facing change?

```release-note
将默认存储策略模板的显示名称改为中文
```
@ruibaby ruibaby deleted the chore/rename-displayname branch March 31, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants