Skip to content

Conversation

@guqing
Copy link
Member

@guqing guqing commented Jun 27, 2024

What this PR does?

/kind improvement

优化插件配置的获取方式

2.17.0 已经对配置获取增加了缓存因此不必在需要插件手动处理

None

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 27, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby June 27, 2024 08:23
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2024
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit ec513c2 into halo-dev:main Jul 4, 2024
ruibaby pushed a commit to ruibaby/plugin-comment-widget that referenced this pull request Aug 8, 2024
)

### What this PR does?
/kind improvement

优化插件配置的获取方式

2.17.0 已经对配置获取增加了缓存因此不必在需要插件手动处理

```release-note
None
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants