Support OAuth2 auto-registration#9940
Draft
JohnNiang wants to merge 2 commits into
Draft
Conversation
f2c-ci-robot
Bot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
f2c-ci-robot
Bot
added
the
needs-rebase
- Replace ReactiveExtensionClient with UserService injection - Use userService.createUser() instead of manual client.create() + RoleBinding.create() - Generate username with UUID instead of relying on generateName - Remove unused ReactiveExtensionClient and RoleBinding imports - Update tests to mock UserService instead of ReactiveExtensionClient
JohnNiang
force-pushed
the
feature/oauth2-auto-registration
branch
from
53859ff to
8851188
Compare
f2c-ci-robot
Bot
removed
the
needs-rebase
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add OAuth2 auto-registration support. When a user logs in via OAuth2 (e.g., GitHub, Google) for the first time without an existing account, Halo will now automatically create a new user account with a generated username instead of redirecting to the manual binding page.
Key changes:
MapOAuth2AuthenticationFilter— AddedautoRegisterUser()method that:Metadata.setGenerateName("user-")displayNameandemailfrom OAuth2 provider attributesUser,RoleBinding, andUserConnectionOAuth2SecurityConfigurer— AddedReactiveExtensionClientandSystemConfigFetcherdependenciesMapOAuth2AuthenticationFilterTest— 5 unit tests covering auto-registration flowNote: This code was generated with assistance from Claude Code (LLM) and has been reviewed for correctness.
Which issue(s) this PR fixes:
Fixes #8120
Ref halo-sigs/plugin-oauth2#77
Does this PR introduce a user-facing change?