-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not cache template result for pre-auth pages #6829
Do not cache template result for pre-auth pages #6829
Conversation
Signed-off-by: JohnNiang <johnniang@foxmail.com>
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6829 +/- ##
=========================================
Coverage 57.03% 57.04%
- Complexity 3978 3991 +13
=========================================
Files 713 714 +1
Lines 23992 24073 +81
Branches 1570 1579 +9
=========================================
+ Hits 13685 13733 +48
- Misses 9696 9727 +31
- Partials 611 613 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/area core
/milestone 2.20.x
What this PR does / why we need it:
This PR prevents caching from cache plugin for pre-auth pages and logout page.
Which issue(s) this PR fixes:
Fixes #6826
Special notes for your reviewer:
Page Cache Plugin
from https://www.halo.run/store/apps/app-BaamQ.Does this PR introduce a user-facing change?