Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not cache template result for pre-auth pages #6829

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind bug
/area core
/milestone 2.20.x

What this PR does / why we need it:

This PR prevents caching from cache plugin for pre-auth pages and logout page.

Which issue(s) this PR fixes:

Fixes #6826

Special notes for your reviewer:

  1. Install Page Cache Plugin from https://www.halo.run/store/apps/app-BaamQ.
  2. Open a private browser window
  3. Access login page twice
  4. Try to login
  5. See the result

Does this PR introduce a user-facing change?

解决因缓存插件缓存登录页面导致无法登录的问题

Signed-off-by: JohnNiang <johnniang@foxmail.com>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Oct 12, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Oct 12, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Oct 12, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from ruibaby and wan92hen October 12, 2024 03:55
Copy link

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.04%. Comparing base (d7aba83) to head (49c2673).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
...un/halo/app/security/LogoutSecurityConfigurer.java 33.33% 2 Missing ⚠️
...lo/app/security/preauth/PreAuthSignUpEndpoint.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6829   +/-   ##
=========================================
  Coverage     57.03%   57.04%           
- Complexity     3978     3991   +13     
=========================================
  Files           713      714    +1     
  Lines         23992    24073   +81     
  Branches       1570     1579    +9     
=========================================
+ Hits          13685    13733   +48     
- Misses         9696     9727   +31     
- Partials        611      613    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2024
Copy link

f2c-ci-robot bot commented Oct 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 0ad565f into halo-dev:main Oct 12, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

使用静态网页缓存插件之后,登录页面会被缓存
3 participants