-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improve password input toggle button state display #6800
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6800 +/- ##
============================================
- Coverage 58.00% 57.71% -0.30%
- Complexity 3977 4020 +43
============================================
Files 696 711 +15
Lines 23517 23917 +400
Branches 1567 1574 +7
============================================
+ Hits 13641 13803 +162
- Misses 9255 9493 +238
Partials 621 621 ☔ View full report in Codecov by Sentry. |
What type of PR is this?
/area ui
/kind improvement
/milestone 2.20.x
What this PR does / why we need it:
优化密码输入框的明文切换图标的状态显示。
before:
after:
Does this PR introduce a user-facing change?