Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve issue with code input can not displaying fullscreen in modal component #6787

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Oct 8, 2024

What type of PR is this?

/area ui
/kind bug
/milestone 2.20.x

What this PR does / why we need it:

修复 Code 输入框在模态框(VModal)组件中无法正常全屏显示的问题。

Which issue(s) this PR fixes:

Fixes #6682

Does this PR introduce a user-facing change?

修复 Code 输入框在模态框(VModal)组件中无法正常全屏显示的问题。

…odal component

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 8, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Oct 8, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from JohnNiang October 8, 2024 07:50
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 8, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from lan-yonghui October 8, 2024 07:50
Copy link

sonarqubecloud bot commented Oct 8, 2024

Copy link

pkg-pr-new bot commented Oct 8, 2024

Open in Stackblitz

@halo-dev/api-client

pnpm add https://pkg.pr.new/@halo-dev/api-client@6787

@halo-dev/components

pnpm add https://pkg.pr.new/@halo-dev/components@6787

@halo-dev/richtext-editor

pnpm add https://pkg.pr.new/@halo-dev/richtext-editor@6787

@halo-dev/console-shared

pnpm add https://pkg.pr.new/@halo-dev/console-shared@6787

@halo-dev/ui-plugin-bundler-kit

pnpm add https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@6787

commit: b27b44c

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.88%. Comparing base (5b2bdfd) to head (b27b44c).
Report is 33 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6787      +/-   ##
============================================
- Coverage     58.00%   57.88%   -0.13%     
- Complexity     3977     4016      +39     
============================================
  Files           696      709      +13     
  Lines         23517    23851     +334     
  Branches       1567     1574       +7     
============================================
+ Hits          13641    13806     +165     
- Misses         9255     9423     +168     
- Partials        621      622       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2024
Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@guqing
Copy link
Member

guqing commented Oct 8, 2024

/approve

Copy link

f2c-ci-robot bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, LIlGG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 1d31d32 into halo-dev:main Oct 8, 2024
10 checks passed
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

在 VModal 中使用 FormKit Code 组件时,全屏模式有样式问题
3 participants