-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: style issue of the fullscreen button in Code input #6785
fix: style issue of the fullscreen button in Code input #6785
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6785 +/- ##
============================================
- Coverage 58.00% 57.88% -0.13%
- Complexity 3977 4017 +40
============================================
Files 696 709 +13
Lines 23517 23851 +334
Branches 1567 1574 +7
============================================
+ Hits 13641 13805 +164
- Misses 9255 9424 +169
- Partials 621 622 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area ui
/kind bug
/milestone 2.20.x
What this PR does / why we need it:
为 Code Input 设置默认高度,修复全屏按钮被遮挡的问题。
Which issue(s) this PR fixes:
Fixes #6681
Does this PR introduce a user-facing change?