-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for setting uniqueId in Dialog to prevent duplicate creation #6737
Conversation
… creation Signed-off-by: Ryan Wang <i@ryanc.cc>
|
@halo-dev/api-client
@halo-dev/components
@halo-dev/richtext-editor
@halo-dev/console-shared
@halo-dev/ui-plugin-bundler-kit
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6737 +/- ##
============================================
- Coverage 58.29% 57.82% -0.48%
- Complexity 3963 3990 +27
============================================
Files 680 704 +24
Lines 23338 23737 +399
Branches 1584 1572 -12
============================================
+ Hits 13604 13725 +121
- Misses 9108 9390 +282
+ Partials 626 622 -4 ☔ View full report in Codecov by Sentry. |
What type of PR is this?
/area ui
/kind feature
/milestone 2.20.x
What this PR does / why we need it:
Dialog API 支持传入 uniqueId,以限制同一时间仅打开一个。
Which issue(s) this PR fixes:
Fixes #6724
Does this PR introduce a user-facing change?