Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support JSON-based retrieval and update for theme and plugin configs #6661

Merged
merged 5 commits into from
Sep 28, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refine UI
  • Loading branch information
ruibaby committed Sep 25, 2024
commit 7e911e9738b5051fa6c195f6b41171da9bbdc523
63 changes: 31 additions & 32 deletions ui/console-src/modules/interface/themes/ThemeSetting.vue
Original file line number Diff line number Diff line change
@@ -1,19 +1,13 @@
<script lang="ts" setup>
// core libs
import { computed, inject, ref, toRaw } from "vue";

// components
import { Toast, VButton } from "@halo-dev/components";

// types
import type { ConfigMap, Setting, Theme } from "@halo-dev/api-client";
import type { Ref } from "vue";

// hooks
import StickyBlock from "@/components/sticky-block/StickyBlock.vue";
import { useSettingFormConvert } from "@console/composables/use-setting-form";
import type { FormKitSchemaCondition, FormKitSchemaNode } from "@formkit/core";
import type { Setting, Theme } from "@halo-dev/api-client";
import { consoleApiClient } from "@halo-dev/api-client";
import { Toast, VButton } from "@halo-dev/components";
import { useQuery, useQueryClient } from "@tanstack/vue-query";
import { cloneDeep, set } from "lodash-es";
import type { Ref } from "vue";
import { computed, inject, ref, toRaw } from "vue";
import { useI18n } from "vue-i18n";

const { t } = useI18n();
Expand All @@ -26,10 +20,10 @@ const setting = inject<Ref<Setting | undefined>>("setting", ref());

const saving = ref(false);

const { data: configMap, suspense } = useQuery<ConfigMap>({
queryKey: ["theme-configMap", selectedTheme],
const { data: configMapData, suspense } = useQuery({
queryKey: ["core:theme:configMap:data", selectedTheme],
queryFn: async () => {
const { data } = await consoleApiClient.theme.theme.fetchThemeConfig({
const { data } = await consoleApiClient.theme.theme.fetchThemeJsonConfig({
name: selectedTheme?.value?.metadata.name as string,
});
return data;
Expand All @@ -39,30 +33,37 @@ const { data: configMap, suspense } = useQuery<ConfigMap>({
}),
});

const { configMapFormData, formSchema, convertToSave } = useSettingFormConvert(
setting,
configMap,
group
);
const currentConfigMapGroupData = computed(() => {
return configMapData.value?.[group.value];
});

const handleSaveConfigMap = async () => {
saving.value = true;
const formSchema = computed(() => {
if (!setting.value) {
return;
}
const { forms } = setting.value.spec;
return forms.find((item) => item.group === group?.value)?.formSchema as (
| FormKitSchemaCondition
| FormKitSchemaNode
)[];
});

const configMapToUpdate = convertToSave();
const handleSaveConfigMap = async (data: object) => {
saving.value = true;

if (!configMapToUpdate || !selectedTheme?.value) {
if (!selectedTheme?.value) {
saving.value = false;
return;
}

await consoleApiClient.theme.theme.updateThemeConfig({
await consoleApiClient.theme.theme.updateThemeJsonConfig({
name: selectedTheme?.value?.metadata.name,
configMap: configMapToUpdate,
body: set(cloneDeep(configMapData.value) || {}, group.value, data),
});

Toast.success(t("core.common.toast.save_success"));

queryClient.invalidateQueries({ queryKey: ["theme-configMap"] });
queryClient.invalidateQueries({ queryKey: ["core:theme:configMap:data"] });

saving.value = false;
};
Expand All @@ -73,18 +74,16 @@ await suspense();
<Transition mode="out-in" name="fade">
<div class="p-4">
<FormKit
v-if="group && formSchema && configMapFormData?.[group]"
v-if="group && formSchema && currentConfigMapGroupData"
:id="group"
v-model="configMapFormData[group]"
:value="currentConfigMapGroupData || {}"
:name="group"
:actions="false"
:preserve="true"
type="form"
@submit="handleSaveConfigMap"
>
<FormKitSchema
:schema="toRaw(formSchema)"
:data="configMapFormData[group]"
:data="toRaw(currentConfigMapGroupData)"
/>
</FormKit>
<StickyBlock
Expand Down
56 changes: 33 additions & 23 deletions ui/console-src/modules/system/plugins/components/tabs/Setting.vue
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
<script lang="ts" setup>
import StickyBlock from "@/components/sticky-block/StickyBlock.vue";
import { useSettingFormConvert } from "@console/composables/use-setting-form";
import type { ConfigMap, Plugin, Setting } from "@halo-dev/api-client";
import type { FormKitSchemaCondition, FormKitSchemaNode } from "@formkit/core";
import type { Plugin, Setting } from "@halo-dev/api-client";
import { consoleApiClient } from "@halo-dev/api-client";
import { Toast, VButton } from "@halo-dev/components";
import { useQuery, useQueryClient } from "@tanstack/vue-query";
import { cloneDeep, set } from "lodash-es";
import { computed, inject, ref, toRaw, type Ref } from "vue";
import { useI18n } from "vue-i18n";

Expand All @@ -16,41 +17,52 @@ const plugin = inject<Ref<Plugin | undefined>>("plugin");
const setting = inject<Ref<Setting | undefined>>("setting", ref());
const saving = ref(false);

const { data: configMap } = useQuery<ConfigMap>({
queryKey: ["plugin-configMap", plugin],
const { data: configMapData } = useQuery({
queryKey: ["core:plugin:configMap:data", plugin],
queryFn: async () => {
const { data } = await consoleApiClient.plugin.plugin.fetchPluginConfig({
name: plugin?.value?.metadata.name as string,
});
const { data } = await consoleApiClient.plugin.plugin.fetchPluginJsonConfig(
{
name: plugin?.value?.metadata.name as string,
}
);
return data;
},
enabled: computed(() => {
return !!setting.value && !!plugin?.value;
}),
});

const { configMapFormData, formSchema, convertToSave } = useSettingFormConvert(
setting,
configMap,
group
);
const currentConfigMapGroupData = computed(() => {
return configMapData.value?.[group.value];
});

const formSchema = computed(() => {
if (!setting.value) {
return;
}
const { forms } = setting.value.spec;
return forms.find((item) => item.group === group?.value)?.formSchema as (
| FormKitSchemaCondition
| FormKitSchemaNode
)[];
});

const handleSaveConfigMap = async () => {
const handleSaveConfigMap = async (data: object) => {
saving.value = true;
const configMapToUpdate = convertToSave();
if (!configMapToUpdate || !plugin?.value) {

if (!plugin?.value) {
saving.value = false;
return;
}

await consoleApiClient.plugin.plugin.updatePluginConfig({
await consoleApiClient.plugin.plugin.updatePluginJsonConfig({
name: plugin.value.metadata.name,
configMap: configMapToUpdate,
body: set(cloneDeep(configMapData.value) || {}, group.value, data),
});

Toast.success(t("core.common.toast.save_success"));

queryClient.invalidateQueries({ queryKey: ["plugin-configMap"] });
queryClient.invalidateQueries({ queryKey: ["core:plugin:configMap:data"] });

saving.value = false;
};
Expand All @@ -60,18 +72,16 @@ const handleSaveConfigMap = async () => {
<div class="rounded-b-base bg-white p-4">
<div>
<FormKit
v-if="group && formSchema && configMapFormData?.[group]"
v-if="group && formSchema && currentConfigMapGroupData"
:id="group"
v-model="configMapFormData[group]"
:value="currentConfigMapGroupData"
:name="group"
:actions="false"
:preserve="true"
type="form"
@submit="handleSaveConfigMap"
>
<FormKitSchema
:schema="toRaw(formSchema)"
:data="configMapFormData[group]"
:data="toRaw(currentConfigMapGroupData)"
/>
</FormKit>
</div>
Expand Down
Loading
Loading