Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add menu select form item #6642

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 12, 2024

What type of PR is this?

/area ui
/kind feature
/milestone 2.20.x

What this PR does / why we need it:

为 FormKit 添加菜单选择输入类型

image

Does this PR introduce a user-facing change?

为 FormKit 添加菜单选择输入类型

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 12, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Sep 12, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 12, 2024
Copy link

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.08%. Comparing base (6cd8dc8) to head (0faef49).
Report is 63 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6642      +/-   ##
============================================
- Coverage     58.18%   58.08%   -0.10%     
- Complexity     3774     3918     +144     
============================================
  Files           651      670      +19     
  Lines         22125    22977     +852     
  Branches       1538     1576      +38     
============================================
+ Hits          12873    13347     +474     
- Misses         8641     9014     +373     
- Partials        611      616       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruibaby ruibaby requested review from JohnNiang, guqing and LIlGG and removed request for lan-yonghui and wzrove September 12, 2024 04:58
@JohnNiang JohnNiang added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Sep 12, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 697963d into halo-dev:main Sep 12, 2024
8 checks passed
@ruibaby ruibaby deleted the feat/menu-select branch September 13, 2024 07:04
f2c-ci-robot bot pushed a commit to halo-dev/docs that referenced this pull request Sep 14, 2024
添加关于 menuSelect 输入类型的文档。

See halo-dev/halo#6642

/kind documentation

```release-note
None
```
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/docs Categorizes an issue or PR as relevant to SIG Docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants