Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct boolean value display issue in formkit selector component #6624

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Sep 10, 2024

What type of PR is this?

/kind bug
/area ui
/milestone 2.20.x

What this PR does / why we need it:

解决 Formkit Selector 在值为布尔或者数字类型时,回显时内容不正常的问题。

How to test it?

测试当 FormKit Select 组件的值为布尔或者数字时,回显的内容是否正常。

Does this PR introduce a user-facing change?

修复 FormKit Select 组件中布尔值的显示问题。

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 10, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Sep 10, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label Sep 10, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and wzrove September 10, 2024 03:31
Copy link

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.04%. Comparing base (6cd8dc8) to head (6358eec).
Report is 58 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6624      +/-   ##
============================================
- Coverage     58.18%   58.04%   -0.14%     
- Complexity     3774     3915     +141     
============================================
  Files           651      670      +19     
  Lines         22125    22970     +845     
  Branches       1538     1575      +37     
============================================
+ Hits          12873    13333     +460     
- Misses         8641     9020     +379     
- Partials        611      617       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LIlGG
Copy link
Member Author

LIlGG commented Sep 10, 2024

/cherry-pick 2.19.x

@halo-dev-bot
Copy link
Collaborator

@LIlGG: once the present PR merges, I will cherry-pick it on top of 2.19.x in a new PR and assign it to you.

In response to this:

/cherry-pick 2.19.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LIlGG
Copy link
Member Author

LIlGG commented Sep 10, 2024

/cherrypick release-2.19

@halo-dev-bot
Copy link
Collaborator

@LIlGG: once the present PR merges, I will cherry-pick it on top of release-2.19 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2024
Copy link

f2c-ci-robot bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 3c785cb into halo-dev:main Sep 10, 2024
8 checks passed
@halo-dev-bot
Copy link
Collaborator

@LIlGG: cannot checkout 2.19.x: error checking out "2.19.x": exit status 1 error: pathspec '2.19.x' did not match any file(s) known to git

In response to this:

/cherry-pick 2.19.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@halo-dev-bot
Copy link
Collaborator

@LIlGG: new pull request created: #6630

In response to this:

/cherrypick release-2.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Sep 10, 2024
…lector component (#6630)

This is an automated cherry-pick of #6624

/assign LIlGG

```release-note
修复 FormKit Select 组件中布尔值的显示问题。
```
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants