-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct boolean value display issue in formkit selector component #6624
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6624 +/- ##
============================================
- Coverage 58.18% 58.04% -0.14%
- Complexity 3774 3915 +141
============================================
Files 651 670 +19
Lines 22125 22970 +845
Branches 1538 1575 +37
============================================
+ Hits 12873 13333 +460
- Misses 8641 9020 +379
- Partials 611 617 +6 ☔ View full report in Codecov by Sentry. |
/cherry-pick 2.19.x |
@LIlGG: once the present PR merges, I will cherry-pick it on top of 2.19.x in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-2.19 |
@LIlGG: once the present PR merges, I will cherry-pick it on top of release-2.19 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@LIlGG: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@LIlGG: new pull request created: #6630 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
/area ui
/milestone 2.20.x
What this PR does / why we need it:
解决 Formkit Selector 在值为布尔或者数字类型时,回显时内容不正常的问题。
How to test it?
测试当 FormKit Select 组件的值为布尔或者数字时,回显的内容是否正常。
Does this PR introduce a user-facing change?