Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve error when adding tables in default editor #6587

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Sep 4, 2024

What type of PR is this?

/kind bug
/area ui
/milestone 2.20.x

What this PR does / why we need it:

在过滤默认编辑器重复扩展时,移除将扩展扁平化的操作。并且若扩展没有 name,则不对其进行过滤,用于解决一些潜在的问题。

How to test it?

测试在默认编辑器中新增 table ,是否会出现报错。

Which issue(s) this PR fixes:

Fixes #6585

Does this PR introduce a user-facing change?

解决在默认编辑器中添加表格报错的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 4, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Sep 4, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label Sep 4, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang September 4, 2024 08:05
Copy link

sonarqubecloud bot commented Sep 4, 2024

@LIlGG
Copy link
Member Author

LIlGG commented Sep 4, 2024

/cherrypick release-2.19

@halo-dev-bot
Copy link
Collaborator

@LIlGG: once the present PR merges, I will cherry-pick it on top of release-2.19 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.04%. Comparing base (6cd8dc8) to head (603c06b).
Report is 51 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6587      +/-   ##
============================================
- Coverage     58.18%   58.04%   -0.15%     
- Complexity     3774     3915     +141     
============================================
  Files           651      670      +19     
  Lines         22125    22963     +838     
  Branches       1538     1574      +36     
============================================
+ Hits          12873    13328     +455     
- Misses         8641     9018     +377     
- Partials        611      617       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前可正常创建表单,但是 Console 仍然抛出了以下错误:

inject.js:1 Port connected
inject.js:1 Port connected
console/posts:1 Unchecked runtime.lastError: A listener indicated an asynchronous response by returning true, but the message channel closed before a response was received
console/posts:1 Unchecked runtime.lastError: A listener indicated an asynchronous response by returning true, but the message channel closed before a response was received
halo-rich-text-editor.iife.3a798b56.js:45 [tiptap warn]: Duplicate extension names found: ['textStyle', 'listItem']. This can lead to issues.
resolve @ halo-rich-text-editor.iife.3a798b56.js:45
Ao @ halo-rich-text-editor.iife.3a798b56.js:45
createExtensionManager @ halo-rich-text-editor.iife.3a798b56.js:123
n_ @ halo-rich-text-editor.iife.3a798b56.js:123
hp @ halo-rich-text-editor.iife.3a798b56.js:125
(anonymous) @ DefaultEditor-B4UtevNE.js:7
await in (anonymous)
(anonymous) @ vue.global.3a798b56.js:9
jt @ vue.global.3a798b56.js:7
Ht @ vue.global.3a798b56.js:7
t.__weh.t.__weh @ vue.global.3a798b56.js:9
rn @ vue.global.3a798b56.js:7
an @ vue.global.3a798b56.js:7
Promise.then
nn @ vue.global.3a798b56.js:7
tn @ vue.global.3a798b56.js:7
(anonymous) @ vue.global.3a798b56.js:9
Se @ vue.global.3a798b56.js:7
ke @ vue.global.3a798b56.js:7
Nt @ vue.global.3a798b56.js:7
set value @ vue.global.3a798b56.js:7
(anonymous) @ vue.global.3a798b56.js:12
Promise.then
setup @ vue.global.3a798b56.js:12
jt @ vue.global.3a798b56.js:7
(anonymous) @ vue.global.3a798b56.js:9
(anonymous) @ vue.global.3a798b56.js:9
M @ vue.global.3a798b56.js:9
F @ vue.global.3a798b56.js:9
v @ vue.global.3a798b56.js:9
N @ vue.global.3a798b56.js:9
L @ vue.global.3a798b56.js:9
v @ vue.global.3a798b56.js:9
c @ vue.global.3a798b56.js:9
run @ vue.global.3a798b56.js:7
B.e.update @ vue.global.3a798b56.js:9
jt @ vue.global.3a798b56.js:7
an @ vue.global.3a798b56.js:7
Promise.then
nn @ vue.global.3a798b56.js:7
tn @ vue.global.3a798b56.js:7
_ @ vue.global.3a798b56.js:7
Se @ vue.global.3a798b56.js:7
Ie @ vue.global.3a798b56.js:7
set @ vue.global.3a798b56.js:7
w @ index-kmCPwD8Q.js:47
await in w
(anonymous) @ index-kmCPwD8Q.js:47
await in (anonymous)
(anonymous) @ vue.global.3a798b56.js:9
jt @ vue.global.3a798b56.js:7
Ht @ vue.global.3a798b56.js:7
t.__weh.t.__weh @ vue.global.3a798b56.js:9
rn @ vue.global.3a798b56.js:7
an @ vue.global.3a798b56.js:7
Promise.then
nn @ vue.global.3a798b56.js:7
tn @ vue.global.3a798b56.js:7
_ @ vue.global.3a798b56.js:7
Se @ vue.global.3a798b56.js:7
ke @ vue.global.3a798b56.js:7
Nt @ vue.global.3a798b56.js:7
set value @ vue.global.3a798b56.js:7
K @ vue-router.global.3a798b56.js:6
(anonymous) @ vue-router.global.3a798b56.js:6
Promise.then
M @ vue-router.global.3a798b56.js:6
$ @ vue-router.global.3a798b56.js:6
navigate @ vue-router.global.3a798b56.js:6
jt @ vue.global.3a798b56.js:7
Ht @ vue.global.3a798b56.js:7
n @ vue.global.3a798b56.js:9

@LIlGG
Copy link
Member Author

LIlGG commented Sep 4, 2024

Promise.then
nn @ vue.global.3a798b56.js:7
tn @ vue.global.3a798b56.js:7
_ @ vue.global.3a798b56.js:7

应该是开发环境的警告,不影响功能。

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 733679d into halo-dev:main Sep 4, 2024
8 checks passed
@halo-dev-bot
Copy link
Collaborator

@LIlGG: new pull request created: #6588

In response to this:

/cherrypick release-2.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Sep 4, 2024
#6588)

This is an automated cherry-pick of #6587

/assign LIlGG

```release-note
解决在默认编辑器中添加表格报错的问题
```
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

升级2.19.0后默认编辑器表格无法使用
5 participants