-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve error when adding tables in default editor #6587
fix: resolve error when adding tables in default editor #6587
Conversation
|
/cherrypick release-2.19 |
@LIlGG: once the present PR merges, I will cherry-pick it on top of release-2.19 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6587 +/- ##
============================================
- Coverage 58.18% 58.04% -0.15%
- Complexity 3774 3915 +141
============================================
Files 651 670 +19
Lines 22125 22963 +838
Branches 1538 1574 +36
============================================
+ Hits 12873 13328 +455
- Misses 8641 9018 +377
- Partials 611 617 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
目前可正常创建表单,但是 Console 仍然抛出了以下错误:
inject.js:1 Port connected
inject.js:1 Port connected
console/posts:1 Unchecked runtime.lastError: A listener indicated an asynchronous response by returning true, but the message channel closed before a response was received
console/posts:1 Unchecked runtime.lastError: A listener indicated an asynchronous response by returning true, but the message channel closed before a response was received
halo-rich-text-editor.iife.3a798b56.js:45 [tiptap warn]: Duplicate extension names found: ['textStyle', 'listItem']. This can lead to issues.
resolve @ halo-rich-text-editor.iife.3a798b56.js:45
Ao @ halo-rich-text-editor.iife.3a798b56.js:45
createExtensionManager @ halo-rich-text-editor.iife.3a798b56.js:123
n_ @ halo-rich-text-editor.iife.3a798b56.js:123
hp @ halo-rich-text-editor.iife.3a798b56.js:125
(anonymous) @ DefaultEditor-B4UtevNE.js:7
await in (anonymous)
(anonymous) @ vue.global.3a798b56.js:9
jt @ vue.global.3a798b56.js:7
Ht @ vue.global.3a798b56.js:7
t.__weh.t.__weh @ vue.global.3a798b56.js:9
rn @ vue.global.3a798b56.js:7
an @ vue.global.3a798b56.js:7
Promise.then
nn @ vue.global.3a798b56.js:7
tn @ vue.global.3a798b56.js:7
(anonymous) @ vue.global.3a798b56.js:9
Se @ vue.global.3a798b56.js:7
ke @ vue.global.3a798b56.js:7
Nt @ vue.global.3a798b56.js:7
set value @ vue.global.3a798b56.js:7
(anonymous) @ vue.global.3a798b56.js:12
Promise.then
setup @ vue.global.3a798b56.js:12
jt @ vue.global.3a798b56.js:7
(anonymous) @ vue.global.3a798b56.js:9
(anonymous) @ vue.global.3a798b56.js:9
M @ vue.global.3a798b56.js:9
F @ vue.global.3a798b56.js:9
v @ vue.global.3a798b56.js:9
N @ vue.global.3a798b56.js:9
L @ vue.global.3a798b56.js:9
v @ vue.global.3a798b56.js:9
c @ vue.global.3a798b56.js:9
run @ vue.global.3a798b56.js:7
B.e.update @ vue.global.3a798b56.js:9
jt @ vue.global.3a798b56.js:7
an @ vue.global.3a798b56.js:7
Promise.then
nn @ vue.global.3a798b56.js:7
tn @ vue.global.3a798b56.js:7
_ @ vue.global.3a798b56.js:7
Se @ vue.global.3a798b56.js:7
Ie @ vue.global.3a798b56.js:7
set @ vue.global.3a798b56.js:7
w @ index-kmCPwD8Q.js:47
await in w
(anonymous) @ index-kmCPwD8Q.js:47
await in (anonymous)
(anonymous) @ vue.global.3a798b56.js:9
jt @ vue.global.3a798b56.js:7
Ht @ vue.global.3a798b56.js:7
t.__weh.t.__weh @ vue.global.3a798b56.js:9
rn @ vue.global.3a798b56.js:7
an @ vue.global.3a798b56.js:7
Promise.then
nn @ vue.global.3a798b56.js:7
tn @ vue.global.3a798b56.js:7
_ @ vue.global.3a798b56.js:7
Se @ vue.global.3a798b56.js:7
ke @ vue.global.3a798b56.js:7
Nt @ vue.global.3a798b56.js:7
set value @ vue.global.3a798b56.js:7
K @ vue-router.global.3a798b56.js:6
(anonymous) @ vue-router.global.3a798b56.js:6
Promise.then
M @ vue-router.global.3a798b56.js:6
$ @ vue-router.global.3a798b56.js:6
navigate @ vue-router.global.3a798b56.js:6
jt @ vue.global.3a798b56.js:7
Ht @ vue.global.3a798b56.js:7
n @ vue.global.3a798b56.js:9
应该是开发环境的警告,不影响功能。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@LIlGG: new pull request created: #6588 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
/area ui
/milestone 2.20.x
What this PR does / why we need it:
在过滤默认编辑器重复扩展时,移除将扩展扁平化的操作。并且若扩展没有 name,则不对其进行过滤,用于解决一些潜在的问题。
How to test it?
测试在默认编辑器中新增 table ,是否会出现报错。
Which issue(s) this PR fixes:
Fixes #6585
Does this PR introduce a user-facing change?