Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for customizing login and logout pages #6488

Merged
merged 2 commits into from
Sep 28, 2024
Merged

Add support for customizing login and logout pages #6488

merged 2 commits into from
Sep 28, 2024

Conversation

JohnNiang
Copy link
Member

@JohnNiang JohnNiang commented Aug 21, 2024 •
edited by ruibaby
Loading

What type of PR is this?

/kind feature
/area core

What this PR does / why we need it:

See #5214 for more.

Which issue(s) this PR fixes:

Fixes #5214
Fixes #5908

Does this PR introduce a user-facing change?

重构登录、注册相关的页面，支持通过主题或者插件扩展

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 21, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from LIlGG August 21, 2024 11:24
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Aug 21, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from wan92hen August 21, 2024 11:24
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from johnniang. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruibaby ruibaby added this to the 2.20.x milestone Aug 27, 2024
@f2c-ci-robot f2c-ci-robot bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 30, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 29.65964% with 434 lines in your changes missing coverage. Please review.

Project coverage is 57.84%. Comparing base (6cd8dc8) to head (8547ffe).
Report is 93 commits behind head on main.

Files with missing lines Patch % Lines
...halo/app/infra/actuator/GlobalInfoServiceImpl.java 8.21% 67 Missing ⚠️
...security/preauth/PreAuthPasswordResetEndpoint.java 15.27% 61 Missing ⚠️
...lo/app/security/preauth/PreAuthSignUpEndpoint.java 20.63% 50 Missing ⚠️
...service/impl/EmailPasswordRecoveryServiceImpl.java 6.97% 40 Missing ⚠️
...alo/app/security/preauth/PreAuthLoginEndpoint.java 22.85% 27 Missing ⚠️
...n/rememberme/WebSessionRememberMeRequestCache.java 7.40% 25 Missing ⚠️
...n/java/run/halo/app/infra/actuator/GlobalInfo.java 0.00% 23 Missing ⚠️
...tion/twofactor/totp/TotpAuthenticationManager.java 14.81% 23 Missing ⚠️
...ava/run/halo/app/core/user/service/SignUpData.java 17.39% 19 Missing ⚠️
...wofactor/totp/TotpCodeAuthenticationConverter.java 10.52% 17 Missing ⚠️
... and 20 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #6488      +/-   ##
============================================
- Coverage     58.18%   57.84%   -0.34%     
- Complexity     3774     3946     +172     
============================================
  Files           651      692      +41     
  Lines         22125    23321    +1196     
  Branches       1538     1565      +27     
============================================
+ Hits          12873    13490     +617     
- Misses         8641     9212     +571     
- Partials        611      619       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guqing guqing mentioned this pull request Sep 12, 2024
Closed
@f2c-ci-robot f2c-ci-robot bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 13, 2024
@ruibaby ruibaby mentioned this pull request Sep 19, 2024
Closed
@ruibaby
Copy link
Member

ruibaby commented Sep 19, 2024

目前还缺少重置密码相关页面

image image

@ruibaby
Copy link
Member

ruibaby commented Sep 19, 2024

如果支持了主题可以覆盖默认的 login.html，建议支持可以在配置文件中禁用这个功能，否则一旦主题提供的模板出现问题，可能导致无法再登录。

@ruibaby
Copy link
Member

ruibaby commented Sep 19, 2024

目前还缺少账号绑定页面，这个页面主要用于 OAuth 登录的场景，如果没有根据 OAuth 的登录信息找到对应的用户，会跳转到账号绑定页面，要么登录已有账号，要么注册新的账号，登录或者注册成功之后会跳转到 Auth Provider 的 bindingUrl。具体逻辑可查阅：https://github.com/halo-dev/halo/blob/main/ui/console-src/views/system/Binding.vue

@f2c-ci-robot f2c-ci-robot bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 23, 2024
@ruibaby ruibaby mentioned this pull request Sep 27, 2024
Merged
JohnNiang and others added 2 commits September 28, 2024 17:37
@JohnNiang
Add backend support for customizing login and logout pages
1f96106 
Signed-off-by: JohnNiang <johnniang@foxmail.com>
@ruibaby @JohnNiang
Add frontend support for customizing login and logout pages
8547ffe 
Signed-off-by: JohnNiang <johnniang@foxmail.com>
@JohnNiang JohnNiang force-pushed the feat/login-logout-pages branch from b6f65d6 to 8547ffe Compare September 28, 2024 09:38
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 28, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
34 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@JohnNiang JohnNiang changed the title WIP: Add support for customizing login and logout pages Add support for customizing login and logout pages Sep 28, 2024
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 28, 2024
@JohnNiang JohnNiang added the tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges. label Sep 28, 2024
@ruibaby ruibaby merged commit 45a08bd into halo-dev:main Sep 28, 2024
7 of 8 checks passed
f2c-ci-robot bot pushed a commit that referenced this pull request Sep 28, 2024
@ruibaby
refactor: remove login-related pages from UI project (#6712)
d523396 
#### What type of PR is this?

/area ui
/kind improvement
/milestone 2.20.x

#### What this PR does / why we need it:

移除 UI 项目中和登录、注册相关的页面和代码，后续将由后端统一提供：#6488

相关 issue：#5214

#### Which issue(s) this PR fixes:

Fixes #5214

#### Does this PR introduce a user-facing change?

```release-note
None 
```
@ruibaby ruibaby mentioned this pull request Sep 28, 2024
Closed
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Sep 28, 2024
This was referenced Sep 29, 2024
Closed
Closed
Closed
Merged
f2c-ci-robot bot pushed a commit that referenced this pull request Sep 29, 2024
@ruibaby
chore: regenerate api client for login-related (#6728)
2c849d8 
#### What type of PR is this?

/area core
/kind cleanup
/milestone 2.20.x

#### What this PR does / why we need it:

重新生成 OpenAPI 定义和 API Client，在 #6488 中忘了重新生成。

#### Does this PR introduce a user-facing change?

```release-note
None
```
This was referenced Oct 4, 2024
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
f2c-ci-robot bot pushed a commit to halo-dev/plugin-comment-widget that referenced this pull request Oct 12, 2024
@ruibaby
refactor: change login url (#157)
3ab7d2f 
Halo 2.20 将提供新的登录入口（/login），此 PR 用于适配新的登录地址。

See more: halo-dev/halo#6488

/kind improvement

```release-note
适配 Halo 2.20 的新登录入口。
```
f2c-ci-robot bot pushed a commit to halo-dev/theme-earth that referenced this pull request Oct 12, 2024
@ruibaby
refactor: change login url (#188)
ea43d6f 
Halo 2.20 将提供新的登录入口（/login），此 PR 用于适配新的登录地址。

See more: halo-dev/halo#6488

/kind improvement

```release-note
适配 Halo 2.20 的新登录入口。
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing guqing left review comments

@LIlGG LIlGG Awaiting requested review from LIlGG

@wan92hen wan92hen Awaiting requested review from wan92hen

Assignees
No one assigned
Labels
area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges.
Projects
None yet
Milestone
2.20.0 LTS
Development

Successfully merging this pull request may close these issues.

login页面优化 重构登录页面，完全交由后端做处理
3 participants
@JohnNiang @ruibaby @guqing