Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the problem that comment reply cannot be displayed in the front end #2954

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Fixed the problem that comment reply cannot be displayed in the front end #2954

merged 2 commits into from
Dec 15, 2022

Conversation

minliacom
Copy link
Contributor

@minliacom minliacom commented Dec 15, 2022 •
edited by JohnNiang
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

/kind api-change

Which issue(s) this PR fixes:

Fixes #2951

Special notes for your reviewer:

Does this PR introduce a user-facing change?

修复开启评论审核的情况下无法显示评论回复的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Dec 15, 2022
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and lan-yonghui December 15, 2022 03:18
guqing
guqing reviewed Dec 15, 2022
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2022
@guqing
Copy link
Member

guqing commented Dec 15, 2022

/remove-kind api-change

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API release-note-none Denotes a PR that doesn't merit a release note. labels Dec 15, 2022
@JohnNiang
Copy link
Member

/cherry-pick release-2.0
/area core

@halo-dev-bot
Copy link
Collaborator

@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.0 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.0
/area core

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Dec 15, 2022
ruibaby
ruibaby reviewed Dec 15, 2022
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 037e14d into halo-dev:main Dec 15, 2022
@halo-dev-bot halo-dev-bot mentioned this pull request Dec 15, 2022
Merged
@halo-dev-bot
Copy link
Collaborator

@JohnNiang: new pull request created: #2965

In response to this:

/cherry-pick release-2.0
/area core

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Dec 15, 2022
@halo-dev-bot
[release-2.0] Fixed the problem that comment reply cannot be displaye…
676f2c7 
…d in the front end (#2965)

This is an automated cherry-pick of #2954

/assign JohnNiang

```release-note
修复开启评论审核的情况下无法显示评论回复的问题
```
@guqing guqing mentioned this pull request Dec 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing guqing left review comments

@ruibaby ruibaby ruibaby approved these changes

@lan-yonghui lan-yonghui Awaiting requested review from lan-yonghui

Assignees

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

前端无法显示评论回复
5 participants
@minliacom @guqing @JohnNiang @halo-dev-bot @ruibaby