Use ruff for linting/formatting #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you're okay with it, I can configure ruff to normalize the string quotation type automatically. Right now, it's set to preserve existing quotes. The diff would have been hard to review with quote normalization enabled. |
steven-johnson
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to make some bigger changes to the buildbot master, namely to use CMake presets inside the repository to drive configuration. But I want a good formatter/linter combo.
We were using flake8 for linting, but when I went to use Black for formatting, it didn't like some of the spacing around
:s or something? At any rate, it's slow and ruff seems great.Run
ruff checkto lint andruff formatto format.