Refactor CI workflows and improve test configuration#9010
Open
alexreinking wants to merge 10 commits intomainfrom
Open
Refactor CI workflows and improve test configuration#9010alexreinking wants to merge 10 commits intomainfrom
alexreinking wants to merge 10 commits intomainfrom
Conversation
alexreinking
added
build
mcourteaux
reviewed
Mar 11, 2026
|
|
||
| # Simd op check tests fix the target features internally, so they | ||
| # only need to be run on one target in CI. Every CI runner targets | ||
| # host, so we can just check for that. |
Contributor
There was a problem hiding this comment.
If every runner targets host, then every runner will simd op check all targets ? Wasn't the goal to not do it redundantly ?
This could be stripped further down to every machine just testing its own architectures op check suite.
Member
Author
There was a problem hiding this comment.
I figured we wanted to make sure cross-compilation worked. But maybe we have enough coverage elsewhere. I'd like @abadams to weigh in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bundles a few changes together (to avoid spending a bunch of CI time these changes are all designed to reduce)
simd_op_checkbuilds on non-host targetstests/(this might be slightly broken; we'll see what CI says. I tested it to work locally, though)Fixes #9009
Fixes #9004