-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix up memoize; bind to Python #8778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rtzam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Compiler Segfaulting when using the added overload
|
Here's a minimal python repro that segfaults at compilation time: from halide import EvictionKey, Func, Var
x = Var("x")
f = Func("f")
f[x] = 0.0
f[x] = f[x] + 1
print("memoize scheduled")
f.memoize()
# f.memoize(EvictionKey(x))
print("JIT compiling...")
f.compile_jit()
print("realizing...")
result = f.realize([3])
print(result) |
|
Documenting slightly smaller test case demonstrating a different symptom: from halide import Func, Var
x = Var("x")
f = Func("f")
f[x] = 0.0
print("memoize scheduled")
f.memoize()
print("JIT compiling...")
f.compile_jit()
print("realizing...")
result = f.realize([3])
print(result)Which generates: f.compile_jit()
~~~~~~~~~~~~~^^
halide.halide_.HalideError: Error: Symbol not found: f.cache_missSo the pure definition is also a bit broken as well as the update step |
|
Failures, although many, are unrelated. |
Fixes #8777