Makefile linker flag fixes and cleanups #8764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexreinking
approved these changes
Aug 15, 2025
Member
alexreinking
left a comment
alexreinking
left a comment
There was a problem hiding this comment.
Glad to see pkg-config used!
Member
|
Typo: |
Member
Author
|
I don't follow why asking brew where libjpeg is so we can tell pkg-config where to find libjpeg so that we can ask pkg-config where libjpeg is is better than just asking brew where libjpeg is. |
abadams
force-pushed
the
abadams/makefile_fixes
branch
from
bca858a to
d74dad3
Compare
Member
Author
|
Test failures are the simd op check vld2 regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.