Skip to content

Adding worker_thread_idle() for more informative profiling #8719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slomp merged 3 commits into from
Aug 20, 2025
Merged

Adding worker_thread_idle() for more informative profiling #8719

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcd5379
wrapping the thread idle condition in a function for more informative…
Aug 13, 2025
c51f16a
making distinction between idle and stall situations
Aug 15, 2025
6c5d606
adding comments about why these functions/symbols were added
Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 26 additions & 15 deletions src/runtime/thread_pool_common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,27 @@ WEAK void dump_job_state() {

WEAK void worker_thread(void *);

WEAK void worker_thread_stall(work *owned_job) {
work_queue.owners_sleeping++;
owned_job->owner_is_sleeping = true;
work_queue.wake_owners.wait(&work_queue.mutex);
owned_job->owner_is_sleeping = false;
work_queue.owners_sleeping--;
}

WEAK void worker_thread_idle() {
work_queue.workers_sleeping++;
if (work_queue.a_team_size > work_queue.target_a_team_size) {
// Transition to B team
work_queue.a_team_size--;
work_queue.wake_b_team.wait(&work_queue.mutex);
work_queue.a_team_size++;
} else {
work_queue.wake_a_team.wait(&work_queue.mutex);
}
work_queue.workers_sleeping--;
}

WEAK void worker_thread_already_locked(work *owned_job) {
while (owned_job ? owned_job->running() : !work_queue.shutdown) {
work *job = work_queue.jobs;
Expand Down Expand Up @@ -330,23 +351,13 @@ WEAK void worker_thread_already_locked(work *owned_job) {

if (!job) {
// There is no runnable job. Go to sleep.
// The "stall" and "idle" function calls are not strictly necessary
// and could be inlined here, but having symbols for these situations
// is very informative when profiling.
if (owned_job) {
work_queue.owners_sleeping++;
owned_job->owner_is_sleeping = true;
work_queue.wake_owners.wait(&work_queue.mutex);
owned_job->owner_is_sleeping = false;
work_queue.owners_sleeping--;
worker_thread_stall(owned_job);
} else {
work_queue.workers_sleeping++;
if (work_queue.a_team_size > work_queue.target_a_team_size) {
// Transition to B team
work_queue.a_team_size--;
work_queue.wake_b_team.wait(&work_queue.mutex);
work_queue.a_team_size++;
} else {
work_queue.wake_a_team.wait(&work_queue.mutex);
}
work_queue.workers_sleeping--;
worker_thread_idle();
}
continue;
}
Expand Down
Loading