Fix build on GCC 15 (Comes with Fedora 42). #8626
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if the namespace issue is a GCC bug, or actually correct language behavior, but the declarations that look like this:
Yield these symbols:
So this behavior is different for GCC when dealing with anonymous namespaces and when dealing with named namespaces. The named namespaces lift
extern "C"declarations out to global scope, whereas the anonymous have them still in the namespace.To be honest, I'm clueless if this
extern "C"inside a namespace makes any sense at all. Doesn't sound very C.