Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer silently hide errors in Metal completion handlers (alternative approach) #8240

Merged
merged 14 commits into from
Jun 14, 2024
Merged

No longer silently hide errors in Metal completion handlers (alternative approach) #8240

merged 14 commits into from
Jun 14, 2024

Commits on May 23, 2024

  1. No longer silently hide errors in Metal completion handlers

    @shoaibkamil
    shoaibkamil committed May 23, 2024
    Configuration menu
    Copy the full SHA
    5a1702f View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Actually implement alternative

    @shoaibkamil
    shoaibkamil committed May 28, 2024
    Configuration menu
    Copy the full SHA
    4386a2a View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Merge branch 'main' into shoaibkamil/metal_completion_handler_error_a… 

    …lternative
    @steven-johnson
    steven-johnson committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    5e05ea7 View commit details
    Browse the repository at this point in the history

  2. clang-format

    @steven-johnson
    steven-johnson committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    4b8a7a5 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Merge remote-tracking branch 'origin/main' into shoaibkamil/metal_com… 

    …pletion_handler_error_alternative
    @shoaibkamil
    shoaibkamil committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    660e038 View commit details
    Browse the repository at this point in the history

  2. Implement new API

    @shoaibkamil
    shoaibkamil committed Jun 7, 2024
    1 Configuration menu
    Copy the full SHA
    a443963 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Implement test and refine the API

    @shoaibkamil
    shoaibkamil committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    79f29d5 View commit details
    Browse the repository at this point in the history

  2. Format.

    @shoaibkamil
    shoaibkamil committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    9270b21 View commit details
    Browse the repository at this point in the history

  3. Remove some debug code

    @shoaibkamil
    shoaibkamil committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    b7ae0fb View commit details
    Browse the repository at this point in the history

  4. Add missing includes.

    @shoaibkamil
    shoaibkamil committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    51eb3aa View commit details
    Browse the repository at this point in the history

  5. Add comment noting why we manually null-terminate after strncpy

    @shoaibkamil
    shoaibkamil committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    faaa65e View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Reverse engineer Objective-C API for passing void* in a block; it tur… 

    …ns out to be much simpler than I thought
    @shoaibkamil
    shoaibkamil committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    3c3a656 View commit details
    Browse the repository at this point in the history

  2. Formatting

    @shoaibkamil
    shoaibkamil committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    c3a11b2 View commit details
    Browse the repository at this point in the history

  3. Don't add const-ness to declaration.

    @shoaibkamil
    shoaibkamil committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    588a59c View commit details
    Browse the repository at this point in the history