Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue where the Halide compiler hits an internal error for bool types in widening intrinsics. #8099

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Fix an issue where the Halide compiler hits an internal error for bool types in widening intrinsics. #8099

merged 2 commits into from
Feb 16, 2024

Commits on Feb 16, 2024

  1. Fix an issue where the Halide compiler hits an internal error when 

    bool types are used with e.g. widening_mul. This situation did not
arise from user code doing this directly, but rather through some
chain o lowering with float16 types. The test cases added to
correctness_intrinsics target the issue directly and do fail without
the fix.

I did not add broader coverage for bool types and intrinsics as it
would require more thinking. Most of them overflow for the true/true
case and thus are of questionable use, however widening operations
cannot overflow... Certainly we could define the language to forbid
this, but currently the frontend does not do so. As indicated above,
the use case driving this was not using bool arithmetic to begin with.
    Z Stern committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    e9e1da4 View commit details
    Browse the repository at this point in the history

  2. Formatting.

    Z Stern committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    5f1e9d3 View commit details
    Browse the repository at this point in the history