Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Module::compile() for some edge cases #7269

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Optimize Module::compile() for some edge cases #7269

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26e99af
Optimize Module::compile() for some edge cases
steven-johnson Jan 10, 2023
2d2077a
Avoid mutation
steven-johnson Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/Module.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,10 +534,20 @@ void Module::compile(const std::map<OutputFileType, std::string> &output_files)
Internal::print_to_html(output_files.at(OutputFileType::stmt_html), *this);
}

// Minor but worthwhile optimization: if all of the output files are of types that won't
// ever rely on submodules (e.g.: toplevel declarations in C/C++), don't bother resolving
// the submodules, which can call compile_to_buffer().
const auto should_ignore_submodules = [](const std::map<OutputFileType, std::string> &output_files) {
const size_t uninteresting_count = output_files.count(OutputFileType::c_header) +
output_files.count(OutputFileType::function_info_header) +
output_files.count(OutputFileType::registration);
return output_files.size() == uninteresting_count;
};

// If there are submodules, recursively lower submodules to
// buffers on a copy of the module being compiled, then compile
// the copied module.
if (!submodules().empty()) {
if (!submodules().empty() && !should_ignore_submodules(output_files)) {
std::map<OutputFileType, std::string> output_files_copy = output_files;
output_files_copy.erase(OutputFileType::stmt);
output_files_copy.erase(OutputFileType::stmt_html);
Expand Down