Skip to content

Fixes for c++20 #6446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2021
Merged

Fixes for c++20 #6446

merged 1 commit into from
Nov 26, 2021

Conversation

abadams
Copy link
Member

@abadams abadams commented Nov 24, 2021

Fixes #6445

@steven-johnson
Copy link
Contributor

The buildbots don't test c++20; I presume someone has done so locally with this test and can verify the fix?

@abadams
Copy link
Member Author

abadams commented Nov 26, 2021

Yes, I did a local build-everything and those were the only issues.

@abadams abadams merged commit 5aeea6a into master Nov 26, 2021
@alexreinking alexreinking deleted the abadams/fix_6445 branch December 7, 2021 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvookin zvookin zvookin approved these changes

@dsharletg dsharletg dsharletg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use of overloaded operator '==' is ambiguous when using c++20
4 participants
@abadams @steven-johnson @zvookin @dsharletg