Backport PR6409 and PR6405 for v13.0.1 #6418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix obscure bug in widening let substitution (cherry picked from commit d343e76)
The existing code attempts to preserve ebx (since the cpuid instruction can trash it), but it only preserves the lower 32 bits; on 64-bit systems, this (amazingly) usually works OK unless you are compiling in (e.g.) ASAN mode, which can subtly change codegen such that the full 32 bits of rbx must be preserved. I'm genuinely astonished this hasn't bitten us before now! (cherry picked from commit 02a394d)
steven-johnson
approved these changes
Nov 15, 2021
|
Okay to rebase and merge? |
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fixes for 6405 and 6409 to cut a v13.0.1 release.
Fix obscure bug in widening let substitution #6405
x86_cpuid_halide must preserve all 64 bits of rbx/rsi #6409
I've left the README.md alone since it seems like v13 wasn't advertised yet, so it still mentions v12.0.0 as the latest release (since that's what is in master right now).
Please look things over and let me know if I've missed anything!