Drop support for MinGW #4601
Drop support for MinGW #4601
Conversation
Not sure if we are ready for this yet or not, but here's a PR that removes all the MinGW if we decide to go that way. (Note that a separate PR for the buildbots will be necessary as well.)
README.md
Outdated
| @@ -133,8 +133,7 @@ To configure and build Halide: | |||
|
|
|||
| #### Building Halide and LLVM on Windows using mingw | |||
|
|
|||
| The makefile method above should work from inside a "mingw64" shell | |||
| (not the default shell) in an msys2 installation. | |||
| Halide no longer supports building via the Makefile under mingw. Windows users should use the CMake build process instead. | |||
There was a problem hiding this comment.
This comment can be misinterpreted to mean that mingw is supported via cmake. We should just delete the mingw section.
Makefile
Outdated
| else | ||
| MAP_FLAGS= -Wl,-Map=$(BUILD_DIR)/llvm_objects/list.all | ||
| LIST_OUTPUT = > /dev/null | ||
| endif | ||
| endif | ||
|
|
||
| $(BUILD_DIR)/llvm_objects/list: $(OBJECTS) $(INITIAL_MODULES) | ||
| # Determine the relevant object files from llvm with a dummy |
There was a problem hiding this comment.
This could be more simplified if we don't support MinGW: We can get rid of LIST_OUTPUT and in line 985 always pipe to /dev/null.
There was a problem hiding this comment.
Done. Also the removal of xargs later in the file.
|
I'm not sure if we should do this yet, but the PR does make a good case that removing MinGW simplifies several pieces of the build process. Otherwise LGTM. Perhaps we should send a message on the halide-dev list as you suggested? |
Done, a couple days ago. No responses as of yet. |
|
So far, not a single complaint about this proposal. How long should we wait for feedback? |
|
I don't think we should wait too long, if nobody speaks up. I'm ok with merging this, but maybe not on a Friday afternoon :) |
|
I just landed the change to the buildbots, so it's definitely not gonna get tested anymore. Might as well approve this one too :-) |
|
Unfortunately LLVM looks like it's failing to build on the buildbots? |
|
Oh DOH, that's because they were running when you landed the changes to the buildbot config. |
alexreinking
changed the title
Not sure if we are ready for this yet or not, but here's a PR that removes all the MinGW if we decide to go that way. (Note that a separate PR for the buildbots will be necessary as well.)
Fixes #4593