Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows releases do not include halide.cmake (and related files) #3658

Closed
cbartnl opened this issue Feb 5, 2019 · 1 comment · Fixed by #4644
Closed

windows releases do not include halide.cmake (and related files) #3658

cbartnl opened this issue Feb 5, 2019 · 1 comment · Fixed by #4644
Labels
build Issues related to building Halide and with CI

Comments

@cbartnl
Copy link

cbartnl commented Feb 5, 2019

Windows builds do not include halide.cmake (and related files). Including these files would make working with halide on windows much easier (particularly now VS2017 has native cmake support). But it seems to depend on some missing config files, which are not generated for windows?
@alexreinking
Copy link
Member

This is getting fixed in #4644 . halide.cmake is deprecated in favor of imported targets / find_package.

@alexreinking alexreinking linked a pull request May 2, 2020 that will close this issue
Modernize CMake #4644
Merged
@alexreinking alexreinking added the build Issues related to building Halide and with CI label May 2, 2020
@alexreinking alexreinking mentioned this issue May 2, 2020
Merged
alexreinking added a commit that referenced this issue May 12, 2020
@alexreinking
Overhaul CMake build. See history in origin/cmake-modern-history.
769b611 
Fixes #870
Fixes #2643
Fixes #2821
Fixes #2852
Fixes #2942
Fixes #3658
Fixes #4009
Fixes #4284
Fixes #4476
Fixes #4581
Fixes #4893
Fixes #4895
alexreinking added a commit that referenced this issue May 12, 2020
@alexreinking
Overhaul CMake build. See history in origin/cmake-modern-history.
4d2dc2f 
Fixes #870
Fixes #2643
Fixes #2821
Fixes #2852
Fixes #2942
Fixes #3658
Fixes #4009
Fixes #4284
Fixes #4476
Fixes #4581
Fixes #4893
Fixes #4895
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues related to building Halide and with CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modernize CMake halide/Halide
2 participants
@alexreinking @cbartnl