feat(math): migrate all operations from Math to StrictMath for Market…

…Comparator
halibobo1205 · Dec 3, 2024 · c01098d · c01098d
1 parent a1afbd2
commit c01098d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/platform/src/main/java/arm/org/tron/common/utils/MarketComparator.java b/platform/src/main/java/arm/org/tron/common/utils/MarketComparator.java
@@ -69,8 +69,8 @@ public static int comparePriceKey(byte[] o1, byte[] o2) {
   public static int comparePrice(long price1SellQuantity, long price1BuyQuantity,
                                  long price2SellQuantity, long price2BuyQuantity) {
     try {
-      return Long.compare(Math.multiplyExact(price1BuyQuantity, price2SellQuantity),
-          Math.multiplyExact(price2BuyQuantity, price1SellQuantity));
+      return Long.compare(StrictMath.multiplyExact(price1BuyQuantity, price2SellQuantity),
+          StrictMath.multiplyExact(price2BuyQuantity, price1SellQuantity));
 
     } catch (ArithmeticException ex) {
       // do nothing here, because we will use BigInteger to compute again
@@ -98,7 +98,7 @@ private static int compareUnsigned(byte[] a, byte[] b) {
     if (b == null) {
       return 1;
     }
-    int minLen = Math.min(a.length, b.length);
+    int minLen = StrictMath.min(a.length, b.length);
     for (int i = 0; i < minLen; ++i) {
       int aVal = a[i] & 0xFF;
       int bVal = b[i] & 0xFF;

diff --git a/platform/src/main/java/x86/org/tron/common/utils/MarketComparator.java b/platform/src/main/java/x86/org/tron/common/utils/MarketComparator.java
@@ -69,8 +69,8 @@ public static int comparePriceKey(byte[] o1, byte[] o2) {
   public static int comparePrice(long price1SellQuantity, long price1BuyQuantity,
                                  long price2SellQuantity, long price2BuyQuantity) {
     try {
-      return Long.compare(Math.multiplyExact(price1BuyQuantity, price2SellQuantity),
-          Math.multiplyExact(price2BuyQuantity, price1SellQuantity));
+      return Long.compare(StrictMath.multiplyExact(price1BuyQuantity, price2SellQuantity),
+          StrictMath.multiplyExact(price2BuyQuantity, price1SellQuantity));
 
     } catch (ArithmeticException ex) {
       // do nothing here, because we will use BigInteger to compute again
@@ -98,7 +98,7 @@ private static int compareUnsigned(byte[] a, byte[] b) {
     if (b == null) {
       return 1;
     }
-    int minLen = Math.min(a.length, b.length);
+    int minLen = StrictMath.min(a.length, b.length);
     for (int i = 0; i < minLen; ++i) {
       int aVal = a[i] & 0xFF;
       int bVal = b[i] & 0xFF;