Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar fixes #39

Merged
merged 3 commits into from
Sep 11, 2020
Merged

Grammar fixes #39

merged 3 commits into from
Sep 11, 2020

Conversation

cobrexus
Copy link
Contributor

Some grammar fixes in CONTRIBUTING.md and README.md, and improvements to sentences structure.

@halfmoonui
Copy link
Owner

halfmoonui commented Sep 10, 2020

Thank you for the PR. One issue is after your change, one statement reads as follows:

Halfmoon's stated goal is really simple - create a customizable frontend framework, has a built-in dark mode, and is great for building dashboards and tools. However, other goals are more implicit:

It doesn't seem correct grammatically. There needs to be a that before has a built-in dark mode.

@cobrexus
Copy link
Contributor Author

@halfmoonui I've updated that line to say:

Halfmoon's stated goal is really simple - create a customizable frontend framework, with a built-in dark mode, that is brilliant for building dashboards and tools. However, our other goals are more implicit:

@halfmoonui halfmoonui merged commit d791779 into halfmoonui:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants