Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of system libraries and github workflows #50

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

araven
Copy link

@araven araven commented Sep 7, 2021

Contribution to build this project with system libraries on Ubuntu focal (20.04) or optional downloads.

@halbux
Copy link
Owner

halbux commented Sep 7, 2021

Hi. Thank you for this contribution! Is it part of the process of packging the lib to make it available in the ubuntu/debian repos for use in Kicad?

@araven
Copy link
Author

araven commented Sep 7, 2021

Hi. Thank you for this contribution! Is it part of the process of packging the lib to make it available in the ubuntu/debian repos for use in Kicad?

Not really. First this is to avoid the lengthy compilation of the downloaded libraries and second to get the benefit of the CI/CD features available from GitHub. I think these commits don’t collide with the actual way of compiling. This just opens extra options.

@halbux
Copy link
Owner

halbux commented Sep 10, 2021

Ok. Is it ok for you to leave the pull request open? This will impact the way I usually compile the code on an everyday basis and the scripts I have here, so I'd prefer not to merge it for now, although I am grateful for this PR.

@nimish
Copy link

nimish commented Feb 10, 2023

this is basically required to get sparselizard to work cleanly -- @halbux it'd be best to have this as the default and then you could override cmake w/ your custom library and include paths in a toolchain config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants