Fix: multiple image-urls in data-background-image #2940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This bug also exists in v3.9. If this version is still maintained, I would also create a MR for this branch. |
Owner
|
Looks good, thanks! There's no reason to patch the 3.9 branch. |
hakimel
added a commit
that referenced
this pull request
Apr 28, 2021
R0bes
pushed a commit
to R0bes/Terraform-Presentation
that referenced
this pull request
Jun 7, 2021
…round Fix: multiple image-urls in data-background-image
R0bes
pushed a commit
to R0bes/Terraform-Presentation
that referenced
this pull request
Jun 7, 2021
srwohl
pushed a commit
to srwohl/phantom-pres
that referenced
this pull request
Sep 2, 2024
|
When I use this feature, only the first image is being displayed. Is there supposed to be a slideshow of backgrounds ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when using the
data-background-imageattribute, the user can only specify one background image. This is, because if a url is given, the whole string given indata-background-imageis wrapped intourl().This MR allows to use a comma-separated list, e.g.:
Would be happy to see this merged into
dev.