Linear Navigation: Fix to work on mobile, fix missing arrows #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earboxer
force-pushed
the
2380-linear-navigation-mobile
branch
from
5384615
to
969e7b3
Compare
hakimel
added a commit
that referenced
this pull request
Jun 10, 2019
|
Merged, thanks! I had to remove the change you made to the control arrows. With that change, the navigation arrows were broken in a presentation that consists only of vertical slides. |
anthqiu
pushed a commit
to anthqiu/ubb_final
that referenced
this pull request
Aug 6, 2019
# By Hakim El Hattab (15) and others # Via GitHub (9) and others * 'dev' of git@github.com:AntSYau/ubb_final.git: (28 commits) Adding missing file to use it properly Update package.json for node 12 support docs: fix typo Tweak to MathJax example readme tweak rephrased hakimel#2378 remove available route changes hakimel#2416 enable url hash for default index.html hakimel#2434 hakimel#2175 add missing comma to MathJax example in README * Mobile Linear Navigation: Fix swipes to navigate linearly * Linear Navigation: Fix showing arrows when last slide has vertical children first/last slide shortcut now uses shift modified, cmd conflicted with browser back/fwd down arrow padding for edge aligned controls avoid exception when highlighting empty code blocks Notes: Weakly enforce a minimum allocated pacing time per slide fix issue where syncSlide would not run/play newly added background content new API methods for getting horizontal/vertical slides, force linear navigation for one-dimensional decks fix the touch devices issues with the down arrow iframe background preload behavior now matches inline iframes + adheres to the new 'preloadIframes' config option Notes: Introduce alternate pacing timer, based on total presentation time ... # Conflicts: # index.html
This was referenced Jan 29, 2020
This was referenced Mar 3, 2020
mstksg
pushed a commit
to mstksg/reveal.js
that referenced
this pull request
Mar 9, 2020
This was referenced Apr 6, 2020
R0bes
pushed a commit
to R0bes/Terraform-Presentation
that referenced
this pull request
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2380
Also close an issue with the arrows not appearing if the last or first slide are vertical stacks.