Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable simpleNavigation #2307

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Enable simpleNavigation #2307

merged 1 commit into from
Jan 22, 2019

Conversation

sestegra
Copy link
Contributor

Most of remote control for presentation only has next/previous button.

To allow the logical progress to be followed with this kind of hardware, arrows should trigger only next and previous slides.

simpleNavigation configuration parameter would be used for that purpose.

I suggest to mix gridNavigation and simpleNavigation configuration parameters into navigationMode to select from one fo following navigation mode:

  • normal (default)
  • simple (this pull request)
  • grid

@hakimel
Copy link
Owner

hakimel commented Jan 22, 2019

Thanks for the PR. I like the idea of a 'navigationMode' config value that incorporates all three of these navigation settings. Gonna take a look at how to best implement it that way.

@hakimel hakimel merged commit fef15ea into hakimel:dev Jan 22, 2019
hakimel added a commit that referenced this pull request Jan 23, 2019
@hakimel
Copy link
Owner

hakimel commented Jan 23, 2019

I've made a number of changes to this:

  1. All options are now part of a new 'navigationMode' config value as suggested.
  2. I renamed 'simple' to 'linear' to try to convey what changes.
  3. When linear is used, the vertical arrows are automatically hidden.
  4. The visible control arrows on screen now follow the same behavior, so clicking the right arrow when 'linear' is enabled will also step through vertical slides.

Here's the documentation:
https://github.com/hakimel/reveal.js/blob/dev/README.md#navigation-mode

@sestegra
Copy link
Contributor Author

@hakimel Keyboard shortcuts table should be updated to display the relevant actions regarding the navigation mode. I created #2313 issue to follow it.

@ShKlinkenberg
Copy link

I'm not getting navigationMode: 'linear', to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants