Decrease specificity of style resets #2248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakimel
added a commit
that referenced
this pull request
Oct 25, 2018
|
Thanks for the PR. I've addressed this in a slightly different way in 6abc6e0 By removing the .reveal prefix we're affecting styling of the page as a whole which might cause styling conflicts with the surround page. Because of that I think it's better to move the reset styles to a separate file so that you can easily leave them out if you want to. |
This was referenced Apr 1, 2019
This was referenced Apr 6, 2020
R0bes
pushed a commit
to R0bes/Terraform-Presentation
that referenced
this pull request
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leading
.revealhas been removed from style resets at the top ofreveal.scss. I hope this PR will be a first step to address the issue #1952.