-
-
Notifications
You must be signed in to change notification settings - Fork 16.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better Search and Modified Zoom #1909
Conversation
Open/close with Control+Shift+f Find words inside SPAN Don't duplicate findings
Block dimension calculation is not accurate, so zoom is made on mouse coordinates Change default modifier to ctrl - alt don't work on Linux New parameter zoomLevel: default 2
@hakimel what do you think? |
Search improvements look great. I don't want to remove the zooming based on element bounds, if it's not working correctly we should fix it instead. It's useful to be able to zoom specific elements rather than a point when you want to, for example, enlarge a whole code block. How about adding the point zoom using a different shortcut than alt + click? |
I turned to point-zoom because I couldn't fix the element zoom. The biggest problem is on fullscreen. Even when it's good on a maximized window, turning fullscreen send the elements to strange places. Maybe the issue is browser-dependent. |
This has been merged into the dev branch 🙌 Played around with the point based zoom and I like how it's more predictable than element based zooming, since element bounds aren't always what you expect them to be. ctrl + click brings up the context menu in OS X so I've made the shortcut platform dependent (ctrl for Linux, alt for all others). |
Open/close with Control+Shift+f
Find words inside SPAN
Don't duplicate findings
Block dimension calculation is not accurate, so zoom is made on mouse coordinates
Change default modifier to ctrl - alt don't work on Linux
New parameter zoomLevel: default 2
Also, can you bless (or curse) the reveal.js editor I'm writing?