Resume video/audio playback if stopped by Reveal.js #1771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 12, 2016 16:30
…a elements, which are not already in paused state.
|
Adding 'data-paused-by-reveal' only if video / audio is not already paused. Now Reveal is not continuing playback for the media elements which it didn't pause. |
|
ping @hakimel |
hakimel
added a commit
that referenced
this pull request
Feb 14, 2017
|
Good catch. That's inconsistent that we were pausing all videos, but only resuming if Has been merged into the dev branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1770
Any comments? :)