Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow display property of visible slide to be configured #1324

Closed
mojavelinux opened this issue Aug 8, 2015 · 1 comment
Closed

Allow display property of visible slide to be configured #1324

mojavelinux opened this issue Aug 8, 2015 · 1 comment
Labels

Comments

@mojavelinux
Copy link
Contributor

The flexbox model is a very useful way to layout slide content. However, at the moment, it's not possible to use the flexbox model for slides because reveal.js is explicitly setting the display CSS property on the current slide to "block". (See https://github.com/hakimel/reveal.js/blob/master/js/reveal.js#L2724).

Please allow the display property of the current slide to be configured so that other slide layouts can be used. In particular, allow the value to be "flex".

I propose the name display for this setting.

Reveal.initialize({
  display: 'flex',
  // ...
});

An alternative is to detect the original display value using getComputedStyle and reuse that value when setting the display CSS property to reveal the current slide.

mojavelinux added a commit to mojavelinux/reveal.js that referenced this issue Aug 8, 2015
- allow display property apply to current slide to be configured
- set flex-direction to column by default in case flexbox is used
mojavelinux added a commit to mojavelinux/reveal.js that referenced this issue Aug 8, 2015
- allow display property apply to current slide to be configured
@Delapouite Delapouite mentioned this issue Nov 9, 2015
@hakimel
Copy link
Owner

hakimel commented Feb 2, 2017

See #1325

@hakimel hakimel closed this as completed Feb 2, 2017
pm-nsimic pushed a commit to chriwu/ps-tec-2017 that referenced this issue May 1, 2017
* resolves hakimel#1324 allow display property to be configured

- allow display property apply to current slide to be configured

* add 'npm build' script that launch grunt

* Allow switching off preview links

The data-preview-link=false tag can be used to switch off preview links

* Support sass extension for custom themes

* Shift `dependencies` to `devDependencies`.

The `reveal.js` npm module is typically installed to access the CSS/JS
assets for Reveal.js. For those that want to run the plugins, they would
clone the whole repository. Hence, it doesn’t make sense to include
those as `dependencies`, which will increase download times.

Closes hakimel#1734.

* Allow background images without protocols to have query hashes/parameters.

Closes hakimel#1603.

* hakimel#1770, resume playback for paused media.

* hakimel#1770, fixed function name.

* hakimel#1770, added second argument for setAttribute

* hakimel#1770, set 'data-paused-by-reveal' attribute only for the media elements, which are not already in paused state.

* support complex markdown

support <textarea data-template> `some code` </textarea>

* Remove 'history: true' from index.html

Readme says the default is 'history: false', so it may be surprising
for users - it's easy to miss the contradicting setting in index.html

* wait for in-slide video/audio to load before playing, reuse same autoplay logic for slide backgrounds

* prevent autoplaying backgrounds from playing if slide is hidden

* fix race condition by updating backgrounds after slide visibility

*  works with video, defaults to  (same as for images)

* remove unused argument

* make backgrounds (iframes) interactive when the foreground is empty

* 2017

* merge info links in index

* fix empty pages in pdf exports (closes hakimel#1804)

* additional fix for empty pages in pdf exports hakimel#1804

* adjust pdf margins instead of heights to fix hakimel#1804

* typo

* note about showNotes in PDF exports hakimel#1800

* fix markdown typo, update comment hakimel#1780

* recommend using textarea wrapper for inline markdown hakimel#1780

* make background videos work on ipad hakimel#1778

* improved fragment notes support hakimel#1636

* warning about cube/page being deprecated hakimel#1774

* adjust comment for display config value hakimel#1325

* added toggleHelp function 

this way a key can be given ability to toggleHelp on and off.  Previously Reveal.showHelp could open the help screen, but no way to close it.

* added override parameter to toggleHelp function

* update deserialize regex to work with decimals

* docs for hakimel#1816 and remove showHelp

* phantom export throws error if reveal.js isn't present

* fix overview rendering issues in latest chrome hakimel#1649

* allow configuration of which view slide number appears on - fixes hakimel#1791

* correct config name in README

* note about deploying multiplex server with now hakimel#1830

* tweaks to showSlideNumber config hakimel#1833

* avoid npe on iframe postMessage

* print-pdf using callback iso timer

Use window.callPhantom icw page. onCallback to wait for pdf-ready event.
From: http://stackoverflow.com/a/28925479/129269

* print-pdf layout slide contents to fit stretch elements

layout() and thereby layoutSlideContents() is never invoked
when isPrintingPdf() is true so stretch elements are not
sized correctly.
This is ensured now by invoking the layoutSlideContents
from SetupPDF(). There seems no need to scale down
like in other PR's is suggested.

* Fix video background autoplay on iOS

* add autoPlayMedia config option, overrides individual autoplay settings

* allow fullscreen for background iframes

* new cli and in-browser pdf printing compatible fix for hakimel#1804

* make pdf page height offset configurable

* replace cdn.mathjax.org with cdnjs

cdn.mathjax.org is shutting down: https://www.mathjax.org/cdn-shutting-down/

This changes the default MathJax URL in the math plugin, as well as
references in README.md and test/examples/math.html

* formatting

* formatting

* clarify meaning of getProgress() value

* expose getPastSlideCount() via public API

This can be used by plugins which are concerned with helping the
presenter with their pace.

* clarify getTotalSlides() returns the number of slides

* add new getSlides() API

This can be used by plugins which are concerned with helping the
presenter with their pace.

* Allow popup window access to Reveal API

* extract time display code into new _displayTime() function

This will allow us to reuse the display code for displaying
an additional pacing timer.

* use opacity for muted clock elements

This allows us to use different colours for different timers,
which will be useful when we add a pacing timer.

* don't mute minutes when hours is unmuted

* avoid deleting existing classes when muting time elements

and make muting work for negative values

* don't show negative signs inside minutes/seconds elements

* round decreasing timers to mirror increasing timers

* document clock and timer in speaker notes window

* optionally display pacing advice based on slide timings

Add an option to display advice on whether the current pace of the
presentation is on track for the right timing (shown as green), and if
not, whether the presenter should speed up (shown as red) or has the
luxury of slowing down (blue).

The pacing timer can be enabled by configuring by the `defaultTiming`
parameter in the `Reveal` configuration block, which specifies the
number of seconds per slide.  120 can be a reasonable rule of thumb.
Timings can also be given per slide `<section>` by setting the
`data-timing` attribute.  Both values are in numbers of seconds.

When the option is enabled, clicking on the timers will reset the timer
to the beginning of the current slide, i.e. as if pacing was perfectly
on track, not to zero as if the presentation had just begun.

* minor tweak for hakimel#1564

* 3.5.0

* * updated big picture slide
* added schema image
* added deployment texts

* * update big picture svg
* adjusted big picture styles
* moved authors and company slides to the end
*

* * added styles for codelistings
* tweaked dockerfile
* added kubernetes cheatsheet
* moved tldr slide to end of presentation

* * added version number to html source
* added config file for CircleCI integration
* added deploy.sh

* * updated status badge
* troubleshooting deploy script

* * bugfix as suggested in https://goo.gl/W1XnSk

* * changed circle badges in readme
* finetuning deploy.sh
* moved sha label to span inside presentation

* * optimized Dockerfile to leverage docker caching

* * added key ‘v’ to toggle display of GIT sha in upper right corner

* * added PS_VERSION_NUMBER to big picture slide
* shortened stateflow texts

* * removed unneeded files

* * added link to github project on tldr

* * changed port for k8-service

* wip

* * finetuning deployment

* debug

* * editorial finetuning

* * extended deploy script to update dyndns with public cluster ip address

* * added shell scripts for starting and stopping the kubernetes (k8) cluster on GCP
* moved it all to subfolder k8

* * huge commit. The best. No seriously, it’s way to big and it can easily serve as a bad example.

* * added seniority
* finetuning claims on last slide
* controls are now hidden

* * extended collaboration slide

* * added samples for collaboration

* * replaced slide bgnd by collage

* * modified collage
* swapped slide order
* added notes
* reduced size of leafs bgnd

* * tweakd tldr slide

* * replaced the bgnd image on the collaboration slide - new one has some effects applied

* * ignoring .vscode folder

* * added data-timing values for every slide
* extended readme section of the repo

* * changed the way how the schema image is built into the slide

* * windows millenium. and why you may never have heard of it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants