Skip to content

Conversation

@simonLeary42
Copy link
Collaborator

@simonLeary42 simonLeary42 commented Nov 17, 2025

This is an alternate version of #18. Here I have made every function call write() immediately, removing the need to consider the possibility of pending modifications.

Pros:

  • simplicity

Cons:

  • web portal code must be updated to remove all uses of write()
    • this is hardly an issue
  • it's no longer possible to buffer changes with many simultaneous calls to appendArray, instead you would have to getAttribute, array_merge, setAttribute
    • since the logic around pending modifications is so broken and production is running just fine, it's clear that we aren't making any use of this feature

@simonLeary42 simonLeary42 force-pushed the correctness3 branch 3 times, most recently from f09cdb4 to 3f40bd0 Compare November 17, 2025 01:08
@simonLeary42 simonLeary42 marked this pull request as ready for review November 17, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants