Audio/Windows: some audio clicking at start of every sound

[divVerent]

This is a regression from v2.1.4 - at current HEAD, there is some noticeable audio clicking in every sound.

NOTE: I don't actually have Windows - there is a slight chance this is actually a WINE issue, but even if it is, it is a regression of ebiten under WINE then.

I recorded the same game audio with WINE/PulseAudio/Audacity and my game's internal audio dumper to demonstrate the difference. At v2.1.4, this clicking does not happen.

Investigation of the wav file shows that the corruption always happens about 400 samples from start of any sound; not sure if there is any relevance to this number. To be clear, it quite surely isn't 512.

windows-sounds.zip

[divVerent]

BTW issue doesn't differ between win32 and win64 builds.

[hajimehoshi]

This is a regression from v2.1.4

Is this a problem not in 2.1 but in main branch?

[divVerent]

The issue never happened in any 2.1 release, but exists in the main branch - yes.

[hajimehoshi]

Sure, thanks.

Could you try ALSA version? a6c52b55ca03daae64bd6372690ac3eba33ddcbc

EDIT: Oops I had a wrong number.

[divVerent]

I don't have that commit yet - for me issue-1761-alsa is at d443f1d. Mean that one? With that one I still have clicks, but very seldomly (once in about two minutes). May even have been pre-existing, it's certainly not at an annoying level and just spamming sounds using arrow keys in my menu also doesn't make it bad.

…

On Tue, Aug 17, 2021 at 9:37 AM Hoshi, Hajime (星一) ***@***.***> wrote: Sure, thanks. Could you try ALSA version? a6c52b5 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1768 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB5NMCLDTPHUOSL5T243ILT5KF47ANCNFSM5CKEKF5Q> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[hajimehoshi]

Sorry the change is for Linux, not for Windows (then I said I had a wrong number).

[divVerent]

Sorry from my end too - responded to the correct bug too now. I assume this change will not affect the Windows binary, so didn't retest on Windows.

…

On Tue, Aug 17, 2021 at 9:58 AM Hoshi, Hajime (星一) ***@***.***> wrote: Sorry the change is for Linux, not for Windows (then I said I had a wrong number). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[hajimehoshi]

Could you try 045b14ba2111f13ed1da7c62ec722e387d138284 for Windows? Thanks!

[hajimehoshi]

ded679c07135db8699e06cb270a32308da984051 I added further improvements based on other people's feedbacks.

[divVerent]

Substantially better. There is some rather minor clicking left which I can repro even in Audacity by creating a sine wave, fading it out and adding a lot of silence at the end - this is likely a HW issue and not ebiten related. So, considering this fixed.

…

On Wed, Aug 18, 2021 at 6:53 AM Hoshi, Hajime (星一) ***@***.***> wrote: Could you try 045b14b for Windows? Thanks! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1768 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB5NMCXXBSM7LHKR26R2Z3T5O3MPANCNFSM5CKEKF5Q> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[hajimehoshi]

Thanks! We've also confirmed some slight clicking noises, but this should be much better than before.

Probably we have to switch a better audio API like WASAPI, but I'll take a look in another milestone.

Thank you for feedbacks and experiments!