Allowing datasources to be defined dynamically #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairyhenderson
force-pushed
the
dynamic-datasource
branch
from
fdf0d2c
to
568a9b4
Compare
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
hairyhenderson
force-pushed
the
dynamic-datasource
branch
from
568a9b4
to
8c64493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #349
Allows
datasource/dsto be given a URL instead of an alias, for situations (like when ranging through a directory datasource) when the URL either can't be known in advance, or is awkward to specify in advance.Behind the scenes, a new datasource is created dynamically, with the URL as the alias. This means the data is cached for multiple uses.
Note that the URL must be an absolute URL in this case.
Signed-off-by: Dave Henderson dhenderson@gmail.com